search

open-iscsi / rtslib-fb

Python library for configuring the Linux kernel-based multiprotocol SCSI target (LIO)
Apache License 2.0
73 stars 90 forks source link

fix invalid literal error for attributes #109

Closed nak3 closed 7 years ago

nak3 commented 7 years ago

fix invalid literal error for attributes

This patch removes a convert string to int for attributes.

Fixes https://github.com/open-iscsi/rtslib-fb/issues/108

agrover commented 7 years ago

Please fix this by changing the except clause to happen for both ValueErrors and InvalidLiteralErrors.

nak3 commented 7 years ago

Ah, I'm sorry this issue has already been fixed. I have been testing with Fedora 26 RPM which still does not include the fix. https://github.com/open-iscsi/rtslib-fb/issues/108 should not happen on current except clause.