search

open-iscsi / rtslib-fb

Python library for configuring the Linux kernel-based multiprotocol SCSI target (LIO)
Apache License 2.0
73 stars 90 forks source link

Relax restrictions on TPG Tag range #173

Closed heroin-moose closed 3 years ago

heroin-moose commented 3 years ago

Currently rtslib forbids TPG Tag 0. According to https://tools.ietf.org/html/rfc7143#section-13.9 this is perfectly legal value, and I've tested it with Linux, Windows, ESXi and AIX initiators.

This commit relaxes the restriction and allows TPG Tag to be 0. I've kept current behavior in automatic tags assignment so nothing changes there (e.g. the first TPG will be 1 unless the user explicitly tells otherwise).

maurizio-lombardi commented 3 years ago

Thanks for the patch, I am going to test it

heroin-moose commented 3 years ago

Thanks for the interest! Any news?

maurizio-lombardi commented 3 years ago

I tested it and it works, I verified that it leaves the default behaviour unchanged and that's a good thing. If there are no objections then I'll merge it soon