open-iscsi / target-isns

Target-isns is an iSNS client for the Linux LIO iSCSI target
GNU General Public License v2.0
16 stars 19 forks source link

Generate multiple PDUs for large count target register message #36

Closed kyle-fortin closed 6 years ago

kyle-fortin commented 6 years ago

For systems with a large number of target ports and/or groups the message may be larger than an isns server can handle and would get dropped. Also, the previous code would SEGV as the 4096 byte message buffer being built up would overrun and corrupt the stack for large registrations.

Signed-off-by: Kyle Fortin kyle.fortin@oracle.com

cvubrugier commented 6 years ago

Very nice! 👍