search

open-iscsi / target-isns

Target-isns is an iSNS client for the Linux LIO iSCSI target
GNU General Public License v2.0
16 stars 19 forks source link

Fix bug #44, Can't update "Device Attr" to window 2008 iSNS server. #45

Closed wncboy closed 6 years ago

wncboy commented 6 years ago

The device has two Ethernet cards, if pull out an ethernet cable, target-isns will not be able to successfully replace "Device Attr" to the server. target-isns should send all target attribute to server when any target state changes.

Signed-off-by: Hao Wu dragonawu@163.com

cvubrugier commented 6 years ago

Thank you for your patch @wncboy. I won't have time to test it until later this week. Please be patient. Portal registration and deregistration has always been difficult because different iSNS servers behave differently. I see that your patch removes some code (that's always good) but the code you remove was added by commit e686df73 to fix a bug during portal registration. Could you test the scenario mentioned in commit e686df73 to verify there is no regression with your fix?

  1. create a target (default portal)
  2. delete the default portal
  3. create portal 1.2.3.4:3260
  4. create portal 5.6.7.8:3260
wncboy commented 6 years ago

OK, I will test this case on open-isns and Windows 2008.

wncboy commented 6 years ago

Hi @cvubrugier , I tested the scenario mentioned in commit e686df7, it can work fine, this patch can fix this issue.