open-iscsi / targetd

Remote configuration of a LIO-based storage appliance
GNU General Public License v3.0
71 stars 28 forks source link

fix: only call wrap_socket when TLS is enabled #101

Closed karelvanhecke closed 7 months ago

karelvanhecke commented 7 months ago

Changes introduced in https://github.com/open-iscsi/targetd/pull/99 break targetd with ssl: false set.

tasleson commented 7 months ago

Good catch, thanks!

Before merging this I created: https://github.com/open-iscsi/targetd/pull/102 which adds no ssl CI test. I want to see that fail first, then I'll merge this which should then allow CI to pass.

tasleson commented 7 months ago

@karelvanhecke Thanks!