open-iscsi / targetd

Remote configuration of a LIO-based storage appliance
GNU General Public License v3.0
71 stars 28 forks source link

block.py: Fix catching exceptions from libblockdev #32

Closed vojtechtrefny closed 5 years ago

vojtechtrefny commented 5 years ago

Libblockdev raises plugin specific exceptions (e.g. LVMError), AttributeError is never raised from libblockdev. Also the 'info' functions raise exceptions for non-existing devices.

tasleson commented 5 years ago

Changes look good, passed tests. Will re-visit return value for thsnapshotcreate.