Open dsonck92 opened 4 years ago
I think these are all reasonable improvement suggestions. As long as we maintain API compatibility we can certainly introduce new functionality. The last point was very apparent when writing the unit tests and I see no reason we couldn't just return all the data about the newly created item. The existing API would probably get sluggish in large configurations. It's good to avoid round tripping in the design. Another option to consider:
Pull requests welcome
Alright, I will pick up some issues then and create some pull requests. In particular the export owner and the feedback part are something I run against as I literally chowned things before the remote system would properly start
As the latest pull requests have been merged in (#55 #56 #58) NFS got a lot more usable. As I'm working on a kubernetes NFS provisioner (to be precise, a targetd provisioner with iSCSI and NFS support) it's pretty much feature complete. However, there are some issues that might need some thought or suggestions:
man exports
. However, as targetd created filesystem volumes are owned by root after creation, this creates permission issues on nfs clients. These can be manually resolved withchown
, but it might be useful to allow NFS to specify the (numeric) user to apply before exporting. (#60)Some general usability points I came across while working with the FS api: