search

open-iscsi / targetd

Remote configuration of a LIO-based storage appliance
GNU General Public License v3.0
71 stars 28 forks source link

Allow running with both libblockdev 3.0 and 2.0 API #94

Closed vojtechtrefny closed 1 year ago

vojtechtrefny commented 1 year ago

The only API change in libblockdev 3.0 affecting targetd is the removal of bd_switch_init_checks function. Dependency checking is now disabled during initialization by defautl so removing this call with 3.0 does not change the behaviour.

tasleson commented 1 year ago

@vojtechtrefny I'm going to get CI working again. Once that is done, we'll get this tested and merged, thanks!

Update: Apparently the CI doesn't merge this with my latest changes (https://github.com/open-iscsi/targetd/pull/95) before it runs CI. Please re-base this PR so we can get CI to run against this change, thanks!

Also run black -t py36 . on the source tree before pushing again (if you didn't already check) as the CI checks for formatting. That needs to be added to the README.md.

vojtechtrefny commented 1 year ago

Once that is done, we'll get this tested and merged, thanks!

Thanks. I rebased this to the latest master.

tasleson commented 1 year ago

@vojtechtrefny Are we needing a new release and packages to pickup this change?

vojtechtrefny commented 1 year ago

@vojtechtrefny Are we needing a new release and packages to pickup this change?

Yes, I plan to release libblockdev 3.0 later next week so having this in rawhide before that would be really nice.

tasleson commented 1 year ago

@vojtechtrefny Are we needing a new release and packages to pickup this change?

Yes, I plan to release libblockdev 3.0 later next week so having this in rawhide before that would be really nice.

New release, fedora rawhide build in progress. Let me know if you need for F38/37 etc.

vojtechtrefny commented 1 year ago

New release, fedora rawhide build in progress. Let me know if you need for F38/37 etc.

Thank you! We need this just for rawhide.