targetcli user:file supports only < 2GB file on 32 bits Linux

[ogck]

In targetcli, under /backstores/user:file

create disk 5G /var/disk.img UserBackedStorageObject creation failed.

In target_core_user.c

struct tcmu_dev { ... size_t dev_size; ... };

size_t is 32 bits in 32 bits Linux.

Can this be fixed?

[lxbsz]

I think yes and do you have any patch about this ?

[mikechristie]

Shoot. The dumb thing is that I did the resize code and updated tcmu_dev_size_store and just assumed everything was 64 bits already.

Here is a kernel patch to update the dev_size to 64 bits in the kernel. I will put up another patch to update runner everywhere.

dev-size64.txt

@ogck

Where are you using tcmu-runner on a 32bit platform? Is it some sort of embedded storage device?

[mikechristie]

Ignore that patch.

Here is a user space fix and in the PR is a tested kernel fix:

https://github.com/open-iscsi/tcmu-runner/pull/360

Closing this issue. We can discuss on the PR.

[ogck]

Raspberry pi 0. Tcmu makes it a usb flash drive.

Cheers, Chun

---

From: mikechristie notifications@github.com Sent: Monday, January 22, 2018 10:05:41 PM To: open-iscsi/tcmu-runner Cc: ogck; Mention Subject: Re: [open-iscsi/tcmu-runner] targetcli user:file supports only < 2GB file on 32 bits Linux (#358)

Closed #358https://github.com/open-iscsi/tcmu-runner/issues/358.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/open-iscsi/tcmu-runner/issues/358#event-1436627551, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AiDAl6bxlbzD6lWBcOctKi_wweYbhagGks5tNXa1gaJpZM4Ro4nB.