search

open-lasso-python / lasso-python

Home of the open-source CAE library lasso-python 🐍
BSD 3-Clause "New" or "Revised" License
50 stars 12 forks source link

sklearn still used as a dependency instead of scikit-learn -> install will gradually fail more and more #36

Closed dani2112 closed 1 year ago

dani2112 commented 1 year ago

🐛 Describe the bug The correct package name for scikit-learn is scikit-learn not sklearn. The sklearn package did work but is now deprecated and implements the brownout strategy, so will gradually increase failure on install. See also https://pypi.org/project/sklearn/. Also see the old issue in the legacy repo from when their were still no issues with failures: https://github.com/open-lasso-python/lasso-python-legacy/issues/15

🔢 To Reproduce Steps to reproduce the behavior: Install during times mentioned in brownout strategy description.

💘 Expected behavior Install the correct package and do not rely on mechanisms that should prevent users from installing malicious code.

🖥️ Setup

codie3611 commented 1 year ago

Thanks for reporting. This will be a quick fix :+1: