open-lasso-python / lasso-python

Home of the open-source CAE library lasso-python 🐍
BSD 3-Clause "New" or "Revised" License
50 stars 12 forks source link

Update version requirements #56

Closed awoimbee closed 1 month ago

awoimbee commented 1 month ago

Fixes #55

This:

Note: lint CI action will likely not pass as I updated black but did not run it (to keep the diff small)

codie3611 commented 1 month ago

Did you update the lock file or regenerate it? Usually regenerating makes less trouble.

awoimbee commented 1 month ago

Flake8 seems dead and doesn't work with newer python libraries, so I replaced it with ruff. Formatting is still done by black (otherwise the diff would be gigantic), but in the future formatting too could be done by ruff.

PS: in femzip_mapper.py I removed duplicateed dict keys (to make ruff happy)

codie3611 commented 1 month ago

We can also transition to ruff in another PR for formatting.

awoimbee commented 1 month ago

We can also transition to ruff in another PR for formatting.

Yep, I don't plan in adding anything to this PR, it's good as-is !

(just in case you're not aware, only you can merge, I don't have the rights, and it's the same for #57)

awoimbee commented 1 month ago

Feel free to merge then

I can't, I don't have the rights to this repo Screenshot from 2024-04-15 14-57-25