search

open-learning-exchange / myplanet

🌕 myPlanet android app reads data from 🌎 for offline use as well as it collect usage data and sends them back to the Planet.
GNU Affero General Public License v3.0
22 stars 25 forks source link

myCourses being visible to guests even when they can never join a course #3602

Closed ewhang5 closed 1 week ago

ewhang5 commented 3 months ago

Should we hide myCourses from guests if they do not have the functionality to ever join a course?

Screenshot 2024-06-12 at 11 49 29 AM
Okuro3499 commented 3 months ago

that would mean also removing the mycourses in Dashboard Screenshot_20240614_175301

xyb994 commented 1 month ago

Looks like this did confuse someone.

From https://discord.com/channels/1079980988421132369/1131244649902772235/1260270809281462465

it was unclear whether I could add courses or not, because there wasn't any button to do so (I imagine you have to be a member to add a course).

Should we keep the add course button but come up with a dialog/toast indicating only registered users can add a course?

Also a side question, should a guest user be allowed to rate since they cannot even "take" the course?

ewhang5 commented 1 month ago

Looks like this did confuse someone.

From https://discord.com/channels/1079980988421132369/1131244649902772235/1260270809281462465

it was unclear whether I could add courses or not, because there wasn't any button to do so (I imagine you have to be a member to add a course).

Should we keep the add course button but come up with a dialog/toast indicating only registered users can add a course?

Also a side question, should a guest user be allowed to rate since they cannot even "take" the course?

I personally think that we should get rid of the myCourses options for guests. I think @xyb994 brought up a great point and that guests should not be allowed to rate courses. @Okuro3499 what do you think about this?

Okuro3499 commented 1 week ago

we solved this by showing a dialog communicating to the guest user to become a member to access mycourses @xyb994 guest users are not able to rate courses Screen_recording_20240902_165939.webm

xyb994 commented 1 week ago

we solved this by showing a dialog communicating to the guest user to become a member to access mycourses @xyb994 guest users are not able to rate courses Screen_recording_20240902_165939.webm

Looks good. I'm closing this!