search

open-learning-exchange / planet

🌍 Planet Learning - Angular application
https://hub.docker.com/r/treehouses/planet
GNU Affero General Public License v3.0
62 stars 39 forks source link

Resource: Filter list height fixes #3455

Open singharpita opened 5 years ago

singharpita commented 5 years ago

Screenshot from 2019-03-21 20-48-23 height should be minimize or made dynamic. instead of blank value it should show "No record" or similar message.

paulbert commented 5 years ago

First we can disable the filter button if there are 1 or fewer options in each of the lists. This is a simpler change that will solve the blank space issue.

Second we can also try to make this dynamic height up to a maximum also if there aren't many items in the list. I believe this will mean the height of the main view-container will have to be set by javascript. Not ideal, and could cause more complication than it's worth, but we can try.