search

open-license-manager / licensecc

Software licensing, copy protection in C++. It has few dependencies and it's cross-platform.
http://open-license-manager.github.io/licensecc/
BSD 3-Clause "New" or "Revised" License
975 stars 310 forks source link

Unit tests failing on HEAD (LCC_PROJECT_NAME not set) #92

Closed nyue closed 4 years ago

nyue commented 4 years ago

Hash : d7aafc200e2229f6d429b24fd77be87d829be711

$ make test Running tests... Test project /home/nyue/projects/Open-License-Manager/OLM/build Start 1: test_license 1/16 Test #1: test_license ..................... Passed 0.01 sec Start 2: test_command-line 2/16 Test #2: test_command-line ................ Passed 0.03 sec Start 3: test_project 3/16 Test #3: test_project ..................... Passed 0.01 sec Start 4: test_cryptohelper 4/16 Test #4: test_cryptohelper ................ Passed 0.08 sec Start 5: test_os_linux 5/16 Test #5: test_os_linux .................... Passed 0.00 sec Start 6: test_license_reader 6/16 Test #6: test_license_reader .............. Passed 0.00 sec Start 7: test_license_locator 7/16 Test #7: test_license_locator ............. Passed 0.00 sec Start 8: test_event_registry 8/16 Test #8: test_event_registry .............. Passed 0.00 sec Start 9: test_network buffer overflow detected : /home/nyue/projects/Open-License-Manager/OLM/build/test/library/os/test_network terminated 9/16 Test #9: test_network .....................Failed 0.00 sec Start 10: test_execution_environment 10/16 Test #10: test_execution_environment ....... Passed 0.00 sec Start 11: test_hw_identifier 11/16 Test #11: test_hw_identifier ............... Passed 0.00 sec Start 12: test_crack 12/16 Test #12: test_crack ....................... Passed 0.01 sec Start 13: test_date 13/16 Test #13: test_date ........................ Passed 0.02 sec Start 14: test_it_hw_identifier buffer overflow detected : /home/nyue/projects/Open-License-Manager/OLM/build/test/functional/test_it_hw_identifier terminated buffer overflow detected : /home/nyue/projects/Open-License-Manager/OLM/build/test/functional/test_it_hw_identifier terminated 14/16 Test #14: test_it_hw_identifier ............Failed 0.02 sec Start 15: test_standard_license 15/16 Test #15: test_standard_license ............ Passed 0.02 sec Start 16: test_signature_verifier 16/16 Test #16: test_signature_verifier .......... Passed 0.02 sec

88% tests passed, 2 tests failed out of 16

Total Test time (real) = 0.25 sec

The following tests FAILED: 9 - test_network (Failed) 14 - test_it_hw_identifier (Failed) Errors while running CTest Makefile:151: recipe for target 'test' failed make: *** [test] Error 8

gcontini commented 4 years ago

Hi nyue, Thanks for reporting again. For reference: your environment is described in issue #77

Junits are ok for at least 8 environments (including my pc). I wonder why i don't see the error.

Are you using any special compiler option that let you discover the buffer overflow?

nyue commented 4 years ago

I am also testing it on a Ubuntu 18.04 that is close to one of your 8 environment, the only difference being that the compiler version is more recent

nyue@head0:~$ cat /etc/lsb-release 
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=18.04
DISTRIB_CODENAME=bionic
DISTRIB_DESCRIPTION="Ubuntu 18.04.4 LTS"
nyue@head0:~$ gcc --version
gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

I have no knowledge about buffer overflow detection and instrumentation to do that, maybe I will just try and run it via valgrind or some address sanitiser.

Thank you.

gcontini commented 4 years ago

Hi Nyue I recently fixed an issue that may be causing to your problem. Can you update and re-test? i tentatively close the bug, if you still have issues please reopen it.