search

open-life-science / open-life-science.github.io

OLS website: web presence and knowledge management for we-are-ols.org
https://we-are-ols.org
MIT License
65 stars 87 forks source link

External document links open on the same tab #859

Closed Tajuddeen1 closed 2 months ago

Tajuddeen1 commented 2 months ago

When you click on a cohort presentation it opens on the same tab. I would suggest we make it open on a new tab instead.

NPDebs commented 2 months ago

@Tajuddeen1 - Can you please clarify if you're referring to the video library?

Tajuddeen1 commented 2 months ago

For example https://we-are-ols.org/openseeds/ols-1/schedule.html#week-02 when you click on the link to the talks it opens in the same tab

yochannah commented 2 months ago

I'm not sure this is a feature we want to implement as there are UX and accessibility implication: https://www.nngroup.com/articles/new-browser-windows-and-tabs/

@bebatut wdyt?

On Fri, 26 Jul 2024 at 14:24, Tajuddeen1 @.***> wrote:

For example https://we-are-ols.org/openseeds/ols-1/schedule.html#week-02 when you click on the link to the talks it opens in the same tab

— Reply to this email directly, view it on GitHub https://github.com/open-life-science/open-life-science.github.io/issues/859#issuecomment-2252760777, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACGXRDWQBJN4JAL5WGHGMXTZOJE2LAVCNFSM6AAAAABLQCIOB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJSG43DANZXG4 . You are receiving this because you are subscribed to this thread.Message ID: <open-life-science/open-life-science.github.io/issues/859/2252760777@ github.com>

bebatut commented 2 months ago

I am also not sure that we want to implement it. I heard the same arguments as @yochannah against it

yochannah commented 2 months ago

okay, that's enough for me in that case. Sorry @Tajuddeen1, this one's a no - please do keep suggesting features and ideas in the future though! 🙏