search

open-lms-open-source / moodle-local_redislock

6 stars 17 forks source link

Passwort variable in README #10

Closed TobiGa closed 3 years ago

TobiGa commented 3 years ago

Hello, when trying out we noticed in README it says passwort should be saved to $CFG->local_redislock_auth. It seems redis is missting. Code references local_redislock_redis_auth. Cheers

dvdcastro commented 3 years ago

$CFG->local_redislock_auth is a config value which is used by the Moodle plugin to connect to Redis, there should be no mention of it in Redis documentation.

We are setting it as an attribute of the class here: https://github.com/open-lms-open-source/moodle-local_redislock/blob/master/classes/lock/redis_lock_factory.php#L96

And then we use it to authenticate with Redis in the auth method. here: https://github.com/open-lms-open-source/moodle-local_redislock/blob/master/classes/lock/redis_lock_factory.php#L377

More documentation on auth can be found here: https://github.com/phpredis/phpredis#auth