search

open-lms-open-source / moodle-plugin-ci

Assist with running a Moodle plugin in Travis CI
https://blackboard-open-source.github.io/moodle-plugin-ci/
GNU General Public License v3.0
43 stars 37 forks source link

Use selenium-firefox docker image version 2.53.1 #116

Open kabalin opened 4 years ago

kabalin commented 4 years ago

Match selenium-firefox version used in https://github.com/moodlehq/moodle-docker (using version 3 will cause failure).

This also adds moodle dir mount to selenium container to allow running file upload tests (https://github.com/blackboard-open-source/moodle-plugin-ci/issues/110#issuecomment-597576207).

Also remove PROFILE env var in .travis.yml to prevent assumption that changing its value to firefox will work (it won't if version remains 3).

james-cnz commented 4 years ago

This change didn't work for me: -v $HOME/build/moodle:$HOME/build/moodle

I got this error:

In ProcessHelper.php line 97:

The command "git clone --depth=1 --branch MOODLE_38_STABLE git://github.com /moodle/moodle.git moodle" failed.

Exit Code: 1(General error)

Working directory: /home/travis/build

Output: ================

Error Output:

Cloning into 'moodle'... /home/travis/build/moodle/.git: Permission denied

This was using a copy of .travis.dist.yml with NVM changed to 14.0 in addition to the changes here.

The change from Firefox 3 to 2.5.3.1 did get Behat working again for me, though.

kabalin commented 4 years ago

Thanks @james-cnz, let me trigger travis and see myself. I might be that we need to start selenium docker instance after moodle installation.

james-cnz commented 4 years ago

It works for me now, thanks.

kabalin commented 4 years ago

Thanks for verifying @james-cnz!

@dvdcastro looks like Travis is no longer enabled on this repo :(