search

open-lms-open-source / moodle-plugin-ci

Assist with running a Moodle plugin in Travis CI
https://blackboard-open-source.github.io/moodle-plugin-ci/
GNU General Public License v3.0
43 stars 37 forks source link

Bump moodle-local_codechecker to 2.9.2 (2.9.3 in fact) #86

Closed kabalin closed 5 years ago

kabalin commented 5 years ago

This is important for PHP 7.3 support. Please refer to moodle-local_codechecker changelog for more details: https://github.com/moodlehq/moodle-local_codechecker/blob/master/CHANGES.md

stronk7 commented 5 years ago

FYI, I had to perform a new release (v2.9.3 tag), because I missed the {{version.php}} bump in the 2.9.2 release. Nothing else changed, so surely it's ok to keep pointing to 2.9.2 here but I had to comment about the new one.

Links:

Sorry for the trouble! Ciao :-)

kabalin commented 5 years ago

Since I had to rebase it following upstream changes, I pointed it to latest 2.9.3 tag.

polothy commented 5 years ago

Ah, bummer! I manually got your PR in with 2.9.3 and pushed it up. Came here to report back and you already fixed it up! Sorry for the trouble, but going to just close this one since I already got it in (which is the important part I think...)

kabalin commented 5 years ago

Heh, no probs, thanks anyway!