search

open-lms-open-source / moodle-plugin-ci

Assist with running a Moodle plugin in Travis CI
https://blackboard-open-source.github.io/moodle-plugin-ci/
GNU General Public License v3.0
43 stars 37 forks source link

php 7.3 support #98

Closed dionysius closed 5 years ago

dionysius commented 5 years ago

Hi, the php 7.3 issue https://github.com/blackboard-open-source/moodle-plugin-ci/issues/82 reported does not apply for my issue:

$ moodle-plugin-ci install
 6/8 [=====================>------]  75% 51 secs [Initialize test suite]
In Execute.php line 104:

  The command "php -d log_errors=1 -d error_log=NULL /home/travis/build/moodl  
  e/admin/tool/behat/cli/util_single_run.php --install" failed.                

  Exit Code: 1(General error)                                                  

  Working directory: /home/travis/build                                        

  Output:                                                                      
  ================                                                             
  == Environment ==                                                            
  !! php !!                                                                    
  version 7.0.0 is required and you are running 7.3.2PHP version 7.3 is not s  
  upported.                                                                    

  Error Output:                                                                
  ================                                                             

install [--moodle MOODLE] [--data DATA] [--repo REPO] [--branch BRANCH] [--plugin PLUGIN] [--db-type DB-TYPE] [--db-user DB-USER] [--db-pass DB-PASS] [--db-name DB-NAME] [--db-host DB-HOST] [--not-paths NOT-PATHS] [--not-names NOT-NAMES] [--extra-plugins EXTRA-PLUGINS] [--no-init]
The command "moodle-plugin-ci install" failed and exited with 1 during .

The config matching to this job log

polothy commented 5 years ago

This is Moodle telling you it doesn't support 7.3. In your build, you are installing Moodle 3.5 and if you check release notes: PHP version: minimum PHP 7.0.0 Note: minimum PHP version has increased since Moodle 3.3. PHP 7.1.x and 7.2.x are supported too. PHP 7.x could have some engine limitations.

https://docs.moodle.org/dev/Moodle_3.5_release_notes

Moodle does cap supported PHP versions so you don't attempt to run Moodle on an untested version of PHP.

dionysius commented 5 years ago

Oh wow, sorry about that, didn't thought of that.

polothy commented 5 years ago

No worries!