search

open-lms-open-source / moodle-theme_snap

GNU General Public License v3.0
79 stars 75 forks source link

Theme update for Moodle3.5 #113

Open sardarfaizan opened 6 years ago

sardarfaizan commented 6 years ago

I need to know when you will update theme for Moodle 3.5

thauska commented 6 years ago

Me too

andrewrowatt-masseyuni commented 6 years ago

Hi! Any indication of date would be useful. We are planning to deploy Moodle 3.5 mid-November. Thanks, Andrew

BirdyOz commented 6 years ago

+1. Thanks in advance.

eLearningLoucoll commented 5 years ago

Us too, with Moodle's new update schedule we will be moving to 3.5 in the next year and would like to know if we can continue to use Snap.

gthomas2 commented 5 years ago

I have a fork of Snap that works reasonably well with Moodle 3.5

https://github.com/gthomas2/moodle-theme_snap

Checkout the MOODLE_35_FIXES branch and do please report any issues you find!

DISCLAIMER: There are some unit / behat tests that are currently failing and I haven't got round to fixing them all yet.

gthomas2 commented 5 years ago

I've updated my fork with a new branch for 35 MOODLE_35_FIXES_PT2

andrewrowatt-masseyuni commented 5 years ago

Thanks @gthomas2

andrewrowatt-masseyuni commented 5 years ago

@gthomas2 my testers have noticed one issue when editing a book - the content editor section is missing due to CSS (my analysis). Ref attached. snap - book resource - missing content editor section v1

TemplemanTwells commented 5 years ago

Is the filepicker working ok for you? I'm on the latest build of 3.5 and when I click on a file button in the Snap settings I get:

[Show/hide message details.] TypeError: selectnode.one(...) is null[Learn More] javascript.php:103:1240 setup_select_file https://.../lib/javascript.php:103:1240 render https://.../lib/javascript.php:119:233 launch https://.../lib/javascript.php:166:153 show https://.../lib/javascript.php:166:119 M.core_filepicker.show https://.../lib/javascript.php:52:90 show_filepicker https://.../lib/javascript.php:34:141 _notify https://.../theme/yui_combo.php:40:43 notify https://.../theme/yui_combo.php:40:240 _notify https://.../theme/yui_combo.php:39:4255 _procSubs https://.../theme/yui_combo.php:39:4911 fireSimple https://.../theme/yui_combo.php:39:4650 _fire https://.../theme/yui_combo.php:39:4534 fire https://.../theme/yui_combo.php:39:4380 _createWrapper/a.fn https://.../theme/yui_combo.php:115:3326