search

open-lms-open-source / moodle-theme_snap

GNU General Public License v3.0
79 stars 75 forks source link

Configuration changes can't be saved #116

Open luislindarte opened 6 years ago

luislindarte commented 6 years ago

Hello, thnaks for this fork, im using moodle 3.4.4, the issue is this: Pressing the save button in certain parts of the site configuration changes are not saved, especially the checkbox, by disabling the snap theme and placing the default theme of moodle the changes can be saved.

In the exmaple im in the advenced features settings panel, i cant save the changes.

capture

igarcia53 commented 6 years ago

Any idea ????

mrvinceo commented 5 years ago

I've got the same issue with 3.4.3, the version now available on Moodle.org. Nothing in the snap theme settings pages are saving, but save fine through the boost theme. Did you ever work this out yourself?

davidscotson commented 5 years ago

You need the hidden input called "save settings" in this file https://github.com/gthomas2/moodle-theme_snap/blob/4f2639b4a804c0da379a71fdee4f8bb6f2a8d594/templates/core_admin/settings.mustache

This was something Moodle changed in 3.4.4 and all themes need updated in order to save settings.

karenrios2010 commented 5 years ago

Here is the theme corrected with the indications of davidscotson snap.zip