search

open-lms-open-source / moodle-theme_snap

GNU General Public License v3.0
79 stars 75 forks source link

Course dashboard grade display is often wrong #134

Closed rrusso closed 4 years ago

rrusso commented 5 years ago

Course dashboard grade display for students is wrong when grade is within the 0 decimal place rounding boundary and the course uses > 0 decimal places for grading.

In classes/course_total_grade.php on line 170 you neglect to call the decimals preference for the course total and never even use the 2 decimal default, therefore it uses PHP default of 0 decimal places which will incorrectly inflate the student grade.

This is a TRIVIAL fix that should not have been overlooked.

dvdcastro commented 4 years ago

Fixed in ea05dc83af8fadaae252b8f3f86c3ecdb3887231 Thanks for reporting