search

open-lms-open-source / moodle-theme_snap

GNU General Public License v3.0
79 stars 75 forks source link

SCSS compile error from lighten function #159

Closed cr0ybot closed 4 years ago

cr0ybot commented 4 years ago

A single line in the SCSS causes the compile to fail and is present in 3.6.3 and 3.7.3:

mod_fcgid: stderr: Debugging: Error while compiling SCSS: Missing argument amount: {...}/theme/snap/scss/_brandcolor.scss on line 708, at column 13, referer: https://{...}/admin/settings.php?section=themesettings

https://github.com/blackboard-open-source/moodle-theme_snap/blob/3c361c796ed5156968f298e169d20279b7f52484/scss/_brandcolor.scss#L708

The lighten() function must have a second parameter (percentage). I had to fix this in both 3.6.3 and 3.7.3 for the CSS to be loaded properly after installing the theme.

dvdcastro commented 4 years ago

Hello,

We commented out this code on b0c1e5fd5 but we'll see how this is affecting things.

Thanks for reporting.