External Tools in Moodle not obeying Launch Container settings when Snap plugin used in Moodle

open-lms-open-source / moodle-theme_snap

GNU General Public License v3.0

79 stars 75 forks source link

External Tools in Moodle not obeying Launch Container settings when Snap plugin used in Moodle #180

Open msilverhls opened 4 years ago

msilverhls commented 4 years ago

We have customers who are using Moodle 3.8 and higher and also use the Snap plugin in their instance of Moodle. When the users add our external tool to their Moodle course and set the launch container = 'New window' the external tool does not open in a new window when launched.

Users that are not using the Snap plugin in Moodle get the correct behavior of having the external tool open in a new window or tab when launched.

msilverhls commented 4 years ago

I was able to reproduce this using a standalone Moodle sandbox with a new Snap plugin with only default settings, not customizations of any kind. With Snap, the external tool opens in a frame, without Snap but the Boost theme instead, the external tool opens in the new tab as expected.