open-lms-open-source / moodle-theme_snap

GNU General Public License v3.0
79 stars 75 forks source link

Theme not compatible with SASSC compiler in 3.9.1 #181

Open tlock opened 4 years ago

tlock commented 4 years ago

When you configure sassc compiler:

$CFG->pathtosassc = '/usr/bin/sassc';

sassc: 3.6.1 libsass: 3.6.4 sass2scss: 1.1.1 sass: 3.5

Running upgrade after removing a plugin will trigger the build of the theme:

PHP Debugging: Error while compiling SCSS: Coding error detected, it must be fixed by a programmer: Error: File to import not found or unreadable: fontawesome/moodle-path. on line 5:1 of ../../theme/snap/scss/_boost.scss from line 157:1 of stdin

@import "fontawesome/moodle-path";

^ in ./lib/outputlib.php on line 1501, stack:

Commenting out further produces errors

PHP Debugging: Error while compiling SCSS: Coding error detected, it must be fixed by a programmer: Error: Incompatible units: 'rem' and 'px'. on line 35:22 of ../../theme/boost/scss/moodle/blocks.scss from line 21:9 of ../../theme/snap/scss/_boost.scss from line 157:9 of stdin

$blocks-plus-gutter: $blocks-column-width + ( $grid-gutter-width / 2 );

---------------------^