search

open-lms-open-source / moodle-theme_snap

GNU General Public License v3.0
79 stars 75 forks source link

Exit Activity Button in Scorm activitiy has no function #189

Open peter-lernyx opened 3 years ago

peter-lernyx commented 3 years ago

Moodle 3.8.6, Snap 3.8.3

Button is not clickable, while it works fine in other templates.

grafik

However, when 'float right' is disabled, the button works as intended, although obviously the display is messed up.

grafik

grafik

peter-lernyx commented 3 years ago

I've had the chance to record the phenomenon, you can clearly see that as the activity fires up, there is a short second where the button still responds, then as the activity actually loads it stops responding. I had the chance to record this as my internet is snail pace today, otherwise I would have never been able to spot this, since this passes by in an instant normally.

See Video

Rabecerra commented 3 years ago

Hi @peter-lernyx, sorry for the really late reply, we are currently working on this and will be available soon.

Thanks for reporting this.

peter-lernyx commented 3 years ago

Hey, since you have released 3.9 now, I will try to migrate asap, hoping that fixes the problem. I will report back after migrating.

peter-lernyx commented 3 years ago

Just upgraded to 3.9, issue persists.

Rabecerra commented 3 years ago

It was updated yesterday for 3.9 in https://github.com/open-lms-open-source/moodle-theme_snap/commit/f5ad2a649c3ce24fbbe101e265db0d5c57c57995

peter-lernyx commented 3 years ago

Awesome, thanks a lot!