search

open-lms-open-source / moodle-theme_snap

GNU General Public License v3.0
79 stars 75 forks source link

Atto Editor acting up, misallignment of menu items in Atto #190

Closed peter-lernyx closed 3 years ago

peter-lernyx commented 3 years ago

Moodle 3.8.6. Snap 3.8.3

https://moodle.org/mod/forum/discuss.php?d=414606

dvdcastro commented 3 years ago

Hi @peter-lernyx

We solved this issue in 8f06e81

We've just responded on the forum thread also and re-release the 3.8.3 version on moodle.org

Let us know if you have any other problem

peter-lernyx commented 3 years ago

Hey, thanks for letting me know, I'll check it out and let you know how it goes. While I have you on, is there a release date for 3.9 stable? We're anxious to migrate to LTS..

peter-lernyx commented 3 years ago

Downloaded V2 from 'Plugins' and installed twice, purged all cashes, ran cron job manually, still no joy grafik

dvdcastro commented 3 years ago

Hello @peter-lernyx,

Downloaded V2 from 'Plugins' and installed twice, purged all cashes, ran cron job manually, still no joy

I'll take a look next week, really weird, it was reported to be fixed by someone else.

Can you confirm you see this in theme/snap/scss/_boost.scss line 52?

@import "moodle/atto";

is there a release date for 3.9 stable?

Most likely, it will be the 1st week of January. But I'll see if we can make that sooner.

peter-lernyx commented 3 years ago

H David, Yes I can confirm. grafik

Thanks for the release info. Christmas or between the years would be a splendid time to upgrade.

daveyboond commented 3 years ago

Downloaded V2 from 'Plugins' and installed twice, purged all cashes, ran cron job manually, still no joy grafik

Just to add that I see the same behaviour as this on my production Moodle (Moo 3.8.6, Snap 3.8.3), but not on my test server (same combination). Must be related to settings.

peter-lernyx commented 3 years ago

I now completely re-installed Moodle 3.8.6 AND also SNAP, i.e. a complete reinstall in the same directory however using the existing database (just as you do in an update but with the same version) and Atto is straight again, i.o.w the above behaviour is no longer there. I used v2 of Snap 3.8.3

grafik

dvdcastro commented 3 years ago

Whoa, I guess a cache purge must have been needed maybe, since there is no version bump, but it's really weird b/c you said you had run the cache purge. Maybe it was a Browser caching issue?

peter-lernyx commented 3 years ago

David, I did all that. Had even re-installed just Atto before, but something somewhere happened that other people also have had happened to their install. Don't know what it is, but even after the complete reinstall my other issue persists (Exit Activity button) for which I have opened another issue here, which that is specific to Snap and doesn't appear in any other theme.

peter-lernyx commented 3 years ago

confirmed on a second production site that this process works. Thanks David!