open-lms-open-source / moodle-theme_snap

GNU General Public License v3.0
79 stars 75 forks source link

Error with Install Snap 3.11.3 on Moodle 3.11.5 #228

Open peter-lernyx opened 2 years ago

peter-lernyx commented 2 years ago

image

Exception - Class 'theme_snap\output\core_renderer' not found Debug info: Error code: generalexceptionmessage Stack trace: line 126 of /theme/snap/settings/snap_basics.php: Error thrown line 32 of /theme/snap/settings.php: call to require() line 57 of /admin/settings/appearance.php: call to include() line 8855 of /lib/adminlib.php: call to require() line 83 of /blocks/admin_bookmarks/block_admin_bookmarks.php: call to admin_get_root() line 341 of /blocks/moodleblock.class.php: call to block_admin_bookmarks->get_content() line 235 of /blocks/moodleblock.class.php: call to block_base->formatted_contents() line 1181 of /lib/blocklib.php: call to block_base->get_content_for_output() line 1239 of /lib/blocklib.php: call to block_manager->create_block_contents() line 374 of /lib/blocklib.php: call to block_manager->ensure_content_created() line 3984 of /lib/outputrenderers.php: call to block_manager->region_has_content() line 40 of /theme/boost/layout/columns2.php: call to core_renderer->blocks() line 1400 of /lib/outputrenderers.php: call to include() line 1330 of /lib/outputrenderers.php: call to core_renderer->render_page_layout() line 2855 of /lib/outputrenderers.php: call to core_renderer->header() line 1945 of /lib/setuplib.php: call to core_renderer->fatal_error() line 390 of /lib/setuplib.php: call to bootstrap_renderer->__call() line ? of unknownfile: call to default_exception_handler()

peter-lernyx commented 2 years ago

Only remedy for now seems to be to completely remove Snap from the install.

tlock commented 2 years ago

On which version of PHP and stack @peter-lernyx ?

peter-lernyx commented 2 years ago

Good point it's 7.3.33 and it's flagged as outdated. Should I try and update maybe?

peter-lernyx commented 2 years ago

Nope after PHP upgrade to 7.4.27 template installs but creates complete mayhem.

I had this in the past when Snap version didn't fit Moodle version. This is Snap 3.33.2 vs Moodle 3.11.5

New debug messages: get_user_field_name() is deprecated. Please use \core_user\fields::get_display_name() instead line 3366 of /lib/deprecatedlib.php: call to debugging() line 42 of /theme/snap/settings/profile_based_branding.php: call to get_user_field_name() line 41 of /theme/snap/settings.php: call to require() line 57 of /admin/settings/appearance.php: call to include() line 8855 of /lib/adminlib.php: call to require() line 40 of /admin/category.php: call to admin_get_root() get_user_field_name() is deprecated. Please use \core_user\fields::get_display_name() instead line 3366 of /lib/deprecatedlib.php: call to debugging() line 43 of /theme/snap/settings/profile_based_branding.php: call to get_user_field_name() line 41 of /theme/snap/settings.php: call to require() line 57 of /admin/settings/appearance.php: call to include() line 8855 of /lib/adminlib.php: call to require() line 40 of /admin/category.php: call to admin_get_root() get_user_field_name() is deprecated. Please use \core_user\fields::get_display_name() instead line 3366 of /lib/deprecatedlib.php: call to debugging() line 44 of /theme/snap/settings/profile_based_branding.php: call to get_user_field_name() line 41 of /theme/snap/settings.php: call to require() line 57 of /admin/settings/appearance.php: call to include() line 8855 of /lib/adminlib.php: call to require() line 40 of /admin/category.php: call to admin_get_root() get_user_field_name() is deprecated. Please use \core_user\fields::get_display_name() instead line 3366 of /lib/deprecatedlib.php: call to debugging() line 45 of /theme/snap/settings/profile_based_branding.php: call to get_user_field_name() line 41 of /theme/snap/settings.php: call to require() line 57 of /admin/settings/appearance.php: call to include() line 8855 of /lib/adminlib.php: call to require() line 40 of /admin/category.php: call to admin_get_root() get_user_field_name() is deprecated. Please use \core_user\fields::get_display_name() instead line 3366 of /lib/deprecatedlib.php: call to debugging() line 46 of /theme/snap/settings/profile_based_branding.php: call to get_user_field_name() line 41 of /theme/snap/settings.php: call to require() line 57 of /admin/settings/appearance.php: call to include() line 8855 of /lib/adminlib.php: call to require() line 40 of /admin/category.php: call to admin_get_root() String [grade,core] is deprecated. Either you should no longer be using that string, or the string has been incorrectly deprecated, in which case you should report this as a bug. Please refer to https://docs.moodle.org/dev/String_deprecation line 394 of /lib/classes/string_manager_standard.php: call to debugging() line 7278 of /lib/moodlelib.php: call to core_string_manager_standard->get_string() line 155 of /mod/lesson/settings.php: call to get_string() line 89 of /lib/classes/plugininfo/mod.php: call to include() line 47 of /admin/settings/plugins.php: call to core\plugininfo\mod->load_settings() line 8857 of /lib/adminlib.php: call to require() line 40 of /admin/category.php: call to admin_get_root()

tlock commented 2 years ago

Those warnings are related to Moodle 3.11.x not PHP, strange that an out of date PHP 7.3.x would cause the issue in the first place.

peter-lernyx commented 2 years ago

I have it working now. When I installed from within Moodle, strangely it pulled an old version of Snap as per the plugin overview.

image

After uninstalling, manually copying the 3.11.3 version directly to the server and upgrading the database, it now works fine and has the right version installed. There still is a debugging message though:

tring [grade,core] is deprecated. Either you should no longer be using that string, or the string has been incorrectly deprecated, in which case you should report this as a bug. Please refer to https://docs.moodle.org/dev/String_deprecation line 394 of /lib/classes/string_manager_standard.php: call to debugging() line 7278 of /lib/moodlelib.php: call to core_string_manager_standard->get_string() line 155 of /mod/lesson/settings.php: call to get_string() line 89 of /lib/classes/plugininfo/mod.php: call to include() line 47 of /admin/settings/plugins.php: call to core\plugininfo\mod->load_settings() line 8857 of /lib/adminlib.php: call to require() line 511 of /lib/classes/plugininfo/base.php: call to admin_get_root() line 1805 of /admin/renderer.php: call to core\plugininfo\base->get_settings_url() line 352 of /admin/renderer.php: call to core_admin_renderer->plugins_control_panel() line 215 of /admin/plugins.php: call to core_admin_renderer->plugin_management_page()

tlock commented 2 years ago

Hi Peter, That is strange because the 3.11.3 version has been uploaded to Moodle Plugins over 7 days ago.

Error you are seeing is from the Lesson module:

line 155 of /mod/lesson/settings.php: call to get_string()

peter-lernyx commented 2 years ago

Oh, excellent, will investigate and report a bug on Moodle. Thanks a lot! ;-)

peter-lernyx commented 2 years ago

Had the same thing again now and think I know what is going on. When you install from inside moodle through the pluging directory link, it downloads and installs this old version somehow. How that gets across the version check I do not know but that's what I did on 3.11.5+ and this is what I got: grafik

peter-lernyx commented 2 years ago

Oh well. Uninstalled Snap, downloaded the snap file manually from the plugin directory and performed a drag and drop install. All checks pass ok, but upon upgrading the database, now this (on 3.11.5+): grafik

and then this:

grafik

xKoetsuji commented 2 years ago

Hello Peter, can you please tell me which PHP version are you using? This must to be fixed just upgrading to PHP 7.4

peter-lernyx commented 2 years ago

I thought I had done this before when this happend last. Let me check

peter-lernyx commented 2 years ago

the hell?? grafik

xKoetsuji commented 2 years ago

Yeah... please try again using PHP 7.4

peter-lernyx commented 2 years ago

waddayaknow... It works again. I am positive that I changed this because everything worked just find before the upgrade to 3.11.5+. have a word with the server admin I gues.. Thank you very much for fixing the same error twice... ;-)