open-lms-open-source / moodle-theme_snap

GNU General Public License v3.0
79 stars 75 forks source link

upload of feedback files for assignments fails #279

Open DavidPruem opened 3 months ago

DavidPruem commented 3 months ago

Hi, one of our lecturers reported a bug that prevents him from uploading feedback files for group assignments when using snap.

Moodle Version: 4.1.10 Snap Version: 4.1.3 (2024040200)

The lecturer uses a current Firefox version on Mac OS, testing with Safari showed the same problem.

Neither clicking on the little document icon nor drag'n drop worked for him.

Following console error occurs: 18:12:00.568 Uncaught TypeError: this.filemanager.one(...) is null view_files https://www.example.org/lib/javascript.php/1714066901/lib/form/filemanager.js:66 render https://www.example.org/lib/javascript.php/1714066901/lib/form/filemanager.js:101 callback https://www.example.org/lib/javascript.php/1714066901/lib/form/filemanager.js:14 complete https://www.example.org/lib/javascript.php/1714066901/lib/form/filemanager.js:11 _notify https://www.example.org/theme/yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js:40 notify https://www.example.org/theme/yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js:40 _notify https://www.example.org/theme/yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js:39 _procSubs https://www.example.org/theme/yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js:39 fireSimple https://www.example.org/theme/yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js:39 _fire https://www.example.org/theme/yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js:39 fire https://www.example.org/theme/yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js:40 _evt https://www.example.org/theme/yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js:206 complete https://www.example.org/theme/yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js:206 _rS https://www.example.org/theme/yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js:206 0 https://www.example.org/pluginfile.php/552234/theme_snap/vendorjs/snap-custom-elements/snap-ce.js:1 invokeTask https://www.example.org/pluginfile.php/552234/theme_snap/vendorjs/snap-custom-elements/snap-ce.js:1 runTask https://www.example.org/pluginfile.php/552234/theme_snap/vendorjs/snap-custom-elements/snap-ce.js:1 invokeTask https://www.example.org/pluginfile.php/552234/theme_snap/vendorjs/snap-custom-elements/snap-ce.js:1 invoke https://www.example.org/pluginfile.php/552234/theme_snap/vendorjs/snap-custom-elements/snap-ce.js:1 0 https://www.example.org/pluginfile.php/552234/theme_snap/vendorjs/snap-custom-elements/snap-ce.js:1 filemanager.js:66:51

I could reproduce the error on firefox on linux mint (drag'n drop worked here, but otherwise the same behaviour).

When the theme is switched to boost the file upload works as expected.