search

open-lv / air-guard

Do-it-yourself electronics kit for building an air quality monitor for your school, work and home.
https://gaisasargs.lv
MIT License
7 stars 3 forks source link

The sed command in flash.sh isn't compatible with Mac OS sed #26

Closed kasparsd closed 2 years ago

kasparsd commented 2 years ago

On Mac OS 10.15.7 I get the following error when flashing:

Firmware filename not supplied, auto-detecting...
Firmware binaries not found
Downloading latest firmware 0.0.7: https://github.com/open-lv/micropython/releases/latest
Using firmware binary: esp32-airguard-firmware-0.0.7.bin
sed: 1: "build/static/sargsAPI.js": undefined label 'uild/static/sargsAPI.js'

probably because of this line:

https://github.com/open-lv/air-guard/blob/43910931cc8a0c3feecdbe2aedb8a4038e0f5f2f/tools/flasher/flash.sh#L103

and how the -i flag works differently between versions of sed.

kasparsd commented 2 years ago

Fixed in 7a9859bb234ad7411063af663b046881b7bd82b2