open-metadata / OpenMetadata

OpenMetadata is a unified metadata platform for data discovery, data observability, and data governance powered by a central metadata repository, in-depth column level lineage, and seamless team collaboration.
https://open-metadata.org
Apache License 2.0
4.93k stars 939 forks source link

Great-Expectation OpenMetadataValidationAction fail in case on update #16560

Open MHajjem opened 1 month ago

MHajjem commented 1 month ago

Affected module Ingestion Framework

Describe the bug Can't to make update on testSuites from GX with OpenMetadataValidationAction.

To Reproduce Launch GX with well configured OpenMetadataValidationAction twice. The first one will pass the second will throw exception

Screenshots or steps to reproduce Launch GX with well configured OpenMetadataValidationAction twice. The first one will pass the second will throw exception

[2024-06-06, 13:53:18 CEST] {validation_operators.py:507} ERROR - Error running action with name update_openmetadata Traceback (most recent call last): File "/var/dte/airflow/python/airflow-venv/lib/python3.8/site-packages/great_expectations/validation_operators/validation_operators.py", line 478, in _run_actions action_result = self.actions[name].run( File "/var/dte/airflow/python/airflow-venv/lib/python3.8/site-packages/great_expectations/checkpoint/actions.py", line 100, in run return self._run( File "/var/dte/airflow/python/airflow-venv/lib/python3.8/site-packages/metadata/great_expectations/action.py", line 153, in _run test_suite = self._check_or_create_test_suite(table_entity) File "/var/dte/airflow/python/airflow-venv/lib/python3.8/site-packages/metadata/great_expectations/action.py", line 251, in _check_or_create_test_suite TestSuite, table_entity.testSuite.fullyQualifiedName.root AttributeError: 'str' object has no attribute 'root'

Expected behavior in case of a testsuite with same name. openmetadata should update lastRun and both results are shown on the test result Interface.

Version:

Additional context Add any other context about the problem here.

harshach commented 1 month ago

@TeddyCr can you review this?