open-metadata / OpenMetadata

OpenMetadata is a unified metadata platform for data discovery, data observability, and data governance powered by a central metadata repository, in-depth column level lineage, and seamless team collaboration.

https://open-metadata.org

Apache License 2.0

5.55k stars 1.05k forks source link

Feature: Allow Custom Property Update in Glossary Bulk Import/export #17919

Closed sonika-shah closed 1 month ago

sonika-shah commented 1 month ago

Describe your changes:

User should be able update custom property when performing a bulk upload at glossary level

https://github.com/user-attachments/assets/b4a7add1-d219-496b-9fc4-aa16856e4744

https://github.com/user-attachments/assets/f5751b45-de71-477c-acd8-4c77143f806f

Type of change:

[ ] Bug fix
[x] Improvement
[x] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

harshach commented 1 month ago

@sonika-shah fieldToInternalArray is unnecessarily complex. You can write the same thing like below using CSVParser


import org.apache.commons.csv.CSVFormat;
import org.apache.commons.csv.CSVParser;
import org.apache.commons.csv.CSVRecord;

public static List<String> fieldToExtensionStrings(String field) throws IOException {
    if (field == null || field.isBlank()) {
        return List.of();
    }

    CSVFormat format = CSVFormat.DEFAULT
            .withDelimiter(';')
            .withQuote('"')
            .withEscape('"') 
            .withRecordSeparator(null); 

    try (CSVParser parser = CSVParser.parse(field, format)) {
        List<String> result = new ArrayList<>();
        for (CSVRecord record : parser) {
            for (String value : record) {
                result.add(value);
            }
        }
        return result;
    }
}```