open-metadata / OpenMetadata

OpenMetadata is a unified metadata platform for data discovery, data observability, and data governance powered by a central metadata repository, in-depth column level lineage, and seamless team collaboration.

https://open-metadata.org

Apache License 2.0

5.26k stars 994 forks source link

fix(ui): GEN-1523 exclude defaultPersona if not present in personas #17940

Closed chirag-madlani closed 6 days ago

chirag-madlani commented 1 week ago

Describe your changes:

Fixes: GEN-1523 #17885

[x] Redshift flakiness for AUT tests
[x] Data insight spec flakiness for AUT
[x] Persist issue with defaultPersona even after removing from persona list

I worked on ... because ...

Type of change:

[ ] Bug fix
[ ] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

notion-workspace[bot] commented 1 week ago

backend: default persona persisted even after persona is removed

github-actions[bot] commented 1 week ago

Jest test Coverage

UI tests summary

Lines	Statements	Branches	Functions
	64.33% (37384/58115)	40.97% (14810/36148)	43.07% (4509/10468)

github-actions[bot] commented 1 week ago

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

sonarcloud[bot] commented 1 week ago

Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud