open-metadata / OpenMetadata

OpenMetadata is a unified metadata platform for data discovery, data observability, and data governance powered by a central metadata repository, in-depth column level lineage, and seamless team collaboration.

https://open-metadata.org

Apache License 2.0

5.26k stars 994 forks source link

minor(ui): reset displayName to avoid being persisted #18024

Open chirag-madlani opened 16 hours ago

chirag-madlani commented 16 hours ago

Describe your changes:

We are setting displayName once and not updating it on receiving prop change
I have added a usEffect to update it
Also scanned same component in case we are having simmiler issue for any other property

Fixes: User displayName being persisted across user

Issue

https://github.com/user-attachments/assets/f39e14dc-37b1-4655-9821-2bd9a84cfe56

Fix

https://github.com/user-attachments/assets/2703bd0e-aa57-489e-8768-9f4fd64f52ee

I worked on ... because ...

#

Type of change:

[ ] Bug fix
[ ] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

#

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

github-actions[bot] commented 16 hours ago

Jest test Coverage

UI tests summary

Lines	Statements	Branches	Functions
	64.27% (37362/58131)	41.07% (14865/36191)	43.09% (4509/10464)

sonarcloud[bot] commented 16 hours ago

Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud