search

open-metadata / OpenMetadata

OpenMetadata is a unified metadata platform for data discovery, data observability, and data governance powered by a central metadata repository, in-depth column level lineage, and seamless team collaboration.
https://open-metadata.org
Apache License 2.0
5.62k stars 1.06k forks source link

Looker Ingestion Cannot Find Aliased Views in Repository #18432

Open REClements opened 4 weeks ago

REClements commented 4 weeks ago

Affected module Ingestion framework

Describe the bug Looker ingestion fails to find views if the view name is aliased using the from parameter in the explore join syntax. Based on the example code below we would expect a failure on the ingestion that gives the error Cannot find the view [view_alias]: empty.

`explore: example { access_filter: { field: example.id user_attribute: id }

join: view_alias { from: actual_view_file_name view_label: "The view we are looking for" type: left_outer relationship: many_to_many sql_on: ${example.id} = ${view_alias.id};; }`

To Reproduce

  1. Configure a looker ingestion to ingest views from a repository
  2. Create a looker explore using the from parameter to reference a view in the join syntax (see example)
  3. Run ingestion

Expected behavior The looker ingestion should be able to parse the join syntax and find the correct view file name by parsing the from parameter.

Version:

Additional context Error encountered ingesting views from Bitbucket.

REClements commented 3 weeks ago

@pmbrull & @harshsoni2024 I was reviewing my looker ingestion failure logs today and noticed something interesting. We also have explores with aliased names using the from parameter. This does not give an error in the logs that the view is missing.

explore: example_explore_alias { label: "Aliased explore name referencing a view" from: actual_view_name }