open-metadata / OpenMetadata

OpenMetadata is a unified metadata platform for data discovery, data observability, and data governance powered by a central metadata repository, in-depth column level lineage, and seamless team collaboration.

https://open-metadata.org

Apache License 2.0

5.55k stars 1.05k forks source link

Fix: Add tag page #18461

Closed sweta1308 closed 3 days ago

sweta1308 commented 2 weeks ago

Fixes #15541 Added tag page which will contain the tag details and the assets.

https://github.com/user-attachments/assets/628f972e-2b39-4c19-9b35-082d35e46530

Type of change:

[ ] Bug fix
[x] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

github-actions[bot] commented 2 weeks ago

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions[bot] commented 2 weeks ago

Jest test Coverage

UI tests summary

Lines	Statements	Branches	Functions
	63.57% (39131/61551)	40.14% (15510/38636)	42.21% (4640/10992)

harshach commented 5 days ago

@sweta1308 it looks we are missing tests on this feature. we should only allow users who have EditTags permission to add assets. If they do not have this or they are admin we should disable the Add Assets button

sonarcloud[bot] commented 3 days ago

Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud