open-metadata / OpenMetadata

OpenMetadata is a unified metadata platform for data discovery, data observability, and data governance powered by a central metadata repository, in-depth column level lineage, and seamless team collaboration.

https://open-metadata.org

Apache License 2.0

5.6k stars 1.05k forks source link

Add Thai languages #18595

Closed codeasai closed 1 week ago

codeasai commented 1 week ago

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

[ ] Bug fix
[ ] Improvement
[x] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

github-actions[bot] commented 1 week ago

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

jgrocha commented 1 week ago

Hi @codeasai ,

I did a similar PR, to add another language.

Maybe you should also update openmetadata-ui/src/main/resources/ui/src/utils/i18next/i18nextUtil.ts. The logic for knowing the browser's accepted languages is in that file. If the browser's first language is th-th, you must tell it to use your th-th.json translations.

This is just a comment from another user. OpenMetadata developers may have a different opinion.

codeasai commented 1 week ago

Hi, @jgrocha

Thank you very much for your advice. I will try to study the subject you mentioned.

github-actions[bot] commented 1 week ago

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] commented 1 week ago

Jest test Coverage

UI tests summary

Lines	Statements	Branches	Functions
	63.56% (39269/61778)	40.15% (15545/38718)	42.24% (4665/11044)

sonarcloud[bot] commented 1 week ago

Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud