open-metadata / OpenMetadata

OpenMetadata is a unified metadata platform for data discovery, data observability, and data governance powered by a central metadata repository, in-depth column level lineage, and seamless team collaboration.

https://open-metadata.org

Apache License 2.0

5.59k stars 1.05k forks source link

fix(ui): GEN-1690 sso token refresh issue for OIDC #18668

Open chirag-madlani opened 5 days ago

chirag-madlani commented 5 days ago

Describe your changes:

Fixes: GEN-1690

Fixes:

Issue with infinite loop on refresh call
Refresh not working for OIDC

Testing done:

[x] Keycloak with refresh with multi tabs
[x] Okta with Refresh with multi tabs
[ ] Azure with Refresh with multi tabs
[x] Basic / LDAP with refresh with multi tabs
[ ] SAML with refresh with multi tabs
[ ] Auth0 with refresh with multi tabs
[ ] Confidential with refresh with multi tabs

#

Type of change:

[ ] Bug fix
[ ] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

#

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

github-actions[bot] commented 3 days ago

Jest test Coverage

UI tests summary

Lines	Statements	Branches	Functions
	63.59% (39839/62648)	40.15% (15812/39385)	42.33% (4724/11159)

notion-workspace[bot] commented 18 hours ago

User Getting Signed Out, need to investigate refresh

sonarcloud[bot] commented 18 hours ago

Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud