Feedback on 0.9 release UI (look and feel/cosmetic issues)

sureshms commented 2 years ago

Let's collect all the feedback related to 0.9 here:

[x] Add hover over on the user icon and show user name and details. See GitHub as an example:
[x] Can we have a little more saturation/vibrant colors for user icons/profiles? They look very dull.
[x] Have consistent user naming. For example name used as post header is different from name that appears in mention:
[x] The paper plane icon could lose the grey box around and just have a grey and purple version (when sending). It could be smaller and subtler.

[x] Make entire User card clickable to get user details in Users page. Right now click is allowed only on the name.

[x] Two ingestion bots appear in Users page

[x] Updated Configure Webhook documentation

[x] URL validation for webhooks may be incorrect. For example: http://localhost or http:// throws validation error:
[x] On the webhook listing page, the filters on the left column are not operational
[x] Change the following text:

to Webhook allows external services to subscribe to the metadata change events. When the event you subscribed for happens, an HTTP POST request is sent to the callback URL provided with the event details. Learn more about the feature in our Webhooks Guide.
[x] Recently search includes some weird strings zzz, zzzz, zzzzd
[x] User search may not be working under Users tab. For example when I search for my name, this is what I see. But Search works fine in Admin tab. Users list should be a superset that should include, Users, Admins, and Bots.
[x] Queries are shown in a very long box. Perhaps this should be similarly sized as activity feed boxes. Also user name (Last run by xxx) shown in a different format compared to posts. We need to decide on what to show for user names across all the pages.

harshach commented 2 years ago

[x] If a entity already exists in recently viewed , do not add that entity again . Example "shopify" appearing multiple times
also it looks like we are adding the database name in the list instead of table_name

vivekratnavel commented 2 years ago

[ ] All the active tabs should have a consistent background color (today, some tabs have a grey background vs white)
[ ] There should be a clear separation between the sidebar and the main content space across all the pages and it should not depend on whether there is more data or less data on the sidebar or the main content space.
[x] Change text: "No description added" -> "No description", "No rules added" -> "No rules" etc.
[ ] Spacing needs to be consistent across all the pages. We should define spacing between the Title text, description and tab content

[x] Fix the spacing in these cards

[x] Fix this

[ ] There should be a link in the user dropdown menu to go to the "Activity Feeds" page.
[x] Searching in the "Users" page does not search "Admins" or "Bots".
[x] The user card in the "Users" page should display the team names instead of just count
[x] Replace "Click here" links with a button
[x] Clean user click for non-admin https://github.com/open-metadata/OpenMetadata/issues/3110
[ ] https://github.com/open-metadata/OpenMetadata/issues/3120
[ ] Clicking the "Reply" button again should close/hide the text editor

[x] The checkboxes on Teams page to add users to team should be square like everywhere else to be consistent
[x] Request description icon should be aligned with the edit icon. It should also have a tooltip that says "Request Description"
[x] The screenshot used as the placeholder for the empty "Activity Feed" tab section should be updated to reflect "data asset" instead of "dataset"
[ ] The button to expand a query should be disabled and not clickable when the query itself is just one line.

harshach commented 2 years ago

[x] For dashboards in recently viewed we are showing the id of a dashboard
For future references, Dashboard names are not unique unlike tables or topics hence we register the id (which can be numerical) so instead of showing id lets depend on displayName

harshach commented 2 years ago

[x] we shouldn't show the "Reply in conversation" instead it show the no.of replies. As we already have "Reply button below the thread
[x] in the above pic we are showing "#fact_session" instead of that show a "table_icon fact_session" text. So that users know this is table

harshach commented 2 years ago

[x] given the settings menu has grown quite a bit for the Admins, lets order them in alphabetical order

darth-coder00 commented 2 years ago

[x] For dashboards in recently viewed we are showing the id of a dashboard

For future references, Dashboard names are not unique unlike tables or topics hence we register the id (which can be numerical) so instead of showing id lets depend on displayName

UI takes displayName for recently viewed section, if displayName is not present, we show name(numeric-id) we get from results

harshach commented 2 years ago

[x] For dashboards in recently viewed we are showing the id of a dashboard

For future references, Dashboard names are not unique unlike tables or topics hence we register the id (which can be numerical) so instead of showing id lets depend on displayName

UI takes displayName for recently viewed section, if displayName is not present, we show name(numeric-id) we get from results

this is not reproducible

vivekratnavel commented 2 years ago

[ ] For dashboards in recently viewed we are showing the id of a dashboard

For future references, Dashboard names are not unique unlike tables or topics hence we register the id (which can be numerical) so instead of showing id lets depend on displayName

UI takes displayName for recently viewed section, if displayName is not present, we show name(numeric-id) we get from results

this is not reproducible

When I tried to assign owner, I was getting this in my activity feed, so we will need to fix this.

Sachin-chaurasiya commented 2 years ago

[ ] For dashboards in recently viewed we are showing the id of a dashboard

For future references, Dashboard names are not unique unlike tables or topics hence we register the id (which can be numerical) so instead of showing id lets depend on displayName

UI takes displayName for recently viewed section, if displayName is not present, we show name(numeric-id) we get from results

this is not reproducible

When I tried to assign owner, I was getting this in my activity feed, so we will need to fix this.

@vivekratnavel, for feed we get about: <#E/dashboard/sample_superset.10/owner> and there fqn is sample_superset.10, so we take the name from fqn and show it in the UI.

sureshms commented 2 years ago

The following issues are not fixed:

[x] Duplicate recently used and searches
[x] Fix the weight of the user profile image and the service icon in data asset details page. Currently user icon looks bigger than the service icon.
[x] Copying to clipboard needs to be consistent. When copying a query (in table details), micro-interaction "Copied" comes up. When copying secret in webhook a message shows up "Copied to clipboard" and stays. Few recommendations. Let's use the same text - "Copied to the clipboard", same text styling, have the same micro-interaction, and green color does not look good. We should explore different coloring options.
[x] Test alignment issues - Tier and Database is slightly higher than Marketplace. Looks like this is an issue everywhere there is a profile picture with Owner (list of topics, dashboards, pipelines etc.)
[x] Webhook listing is bland with no separation between texts. We should add perhaps webhook icon like this - https://icon-icons.com/icon/webhook/138018
[x] Sorting should be based on the last reply and not thread creation time. cc @vivekratnavel
[ ] Use consistent line-based icons with the same consistent grey color (this is from generate a secret key on webhooks page). We should change the trashcan/delete icons everywhere.
[ ] Need a profile picture for ingestion bot
[x] Primary key in lineage UI remains in the same place as you scroll through different columns/details of an entity: