open-metadata / OpenMetadata

OpenMetadata is a unified metadata platform for data discovery, data observability, and data governance powered by a central metadata repository, in-depth column level lineage, and seamless team collaboration.
https://open-metadata.org
Apache License 2.0
5.55k stars 1.05k forks source link

UI Create property URL dynamically #4697

Closed pmbrull closed 2 years ago

pmbrull commented 2 years ago

Feature

Describe the task

We have Entities with properties that represent URLs. For example:

We currently inform that property during the ingestion process as a string, which contains the full URL. E.g., http://localhost:8080/my/task/url. However, the services (in this case, PipelineService or DashboardService), also have in their connection description a hostPort attribute.

We allow to update the connection URL of the services in the UI, but this change is not reflected properly in the tasks and charts URLs, as that information is not dynamic.

In this feature, we are going to revamp how we are ingesting and exploiting this information in the UI:

This way, all the changes and fixes done on the service side will be properly reflected in its children's attributes.

IMPORTANT: Not all services have a hostPort property. For example, PowerBI is a hosted service and we only give client/secret information to connect. Therefore, we will create the URL as {hostPort}/{urlSuffix} for those services that do have hostPort. Otherwise, just show the URL as it comes from the backend.

pmbrull commented 2 years ago

cc @vivekratnavel, added M3 tentatively 🙏