[BUG]: missing reference to `modules.generic.conv` in `modules/encoder/conv_encoder.py`

[karljeon44]

Describe the bug

(A clear and concise description of what the bug is.)

modules/encoder/conv_encoder.py attempts to import from modules.generic package, as follows:

import torch
...
from modules.generic.conv import Conv1d

but generic is clearly missing from inside modules

Perhaps you meant conv.py inside wavenet??

How To Reproduce

Steps to reproduce the behavior:

1. Config/File changes: N/A
2. Run command:
   • Run any file that imports from conv_encoder, for instance:

     from modules.encoder.conv_encoder import ConvEncoder

3. See error:

Expected behavior

(A clear and concise description of what you expected to happen.)

• Above exception not raised

Screenshots

(If applicable, add screenshots to help explain your problem.)

• see above

Environment Information

• irrelevant

Additional context

(Add any other context about the problem here.)

• modules/encoder/conv_encoder.py is the only occurrence of this issue

[Adorable-Qin]

Hi @karljeon44 ! Thank you very much for your feedback about Amphion!

conv_encoder.py is a deprecated file left over from the old implementation, that's why it contains invalid reference. I've removed it to avoid unintended import operation which may cause crash. If you want to check our self-defined Conv1d function, you may find it at /modules/general/utils.py.

Feel free to ask if you have any other question, we are delight to help!