[Feature]: Replace hand-craft hparams with dataclass and omegaconf framework

open-mmlab / Amphion

Amphion (/æmˈfaɪən/) is a toolkit for Audio, Music, and Speech Generation. Its purpose is to support reproducible research and help junior researchers and engineers get started in the field of audio, music, and speech generation research and development.

https://openhlt.github.io/amphion/

MIT License

4.28k stars 364 forks source link

[Feature]: Replace hand-craft hparams with dataclass and omegaconf framework #198

Open Nugine opened 2 months ago

Nugine commented 2 months ago

Is your feature request related to a problem? Please describe.

The config file does not have a typed definition. IDE can not perform type check on config variables. It makes contributors harder to understand the codebase.

Describe the solution you'd like

Use dataclasses to define structured config classes.
Use omegaconf to load/save the config files.

RMSnow commented 2 months ago

Hi @Nugine, thanks for your insightful suggestions! We will investigate the two tools soon! (cc @Adorable-Qin)