open-mmlab / OpenPCDet

OpenPCDet Toolbox for LiDAR-based 3D Object Detection.

Apache License 2.0

4.57k stars 1.28k forks source link

Typo in train.py? #752

Closed JenWei0312 closed 2 years ago

JenWei0312 commented 2 years ago

thought

L189 args.start_epoch = max(args.epochs - 0, 0)

should be 'args.epochs - 0'? Thanks

LouisSF commented 2 years ago

If you want to evaluate the last 10epochs, as implied by the comment following this line, then this is a type and should be replaced with args.start_epoch = max(args.epochs - 10, 0)

sshaoshuai commented 2 years ago

Thanks. Fixed in https://github.com/open-mmlab/OpenPCDet/pull/770.