[CodeCamp2023-652] MMagic 新 config 体验与适配 StyleGAN3

hhy150 commented 1 year ago

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

(1) Changed the name of the configuration file to comply with the Python module name specification, with only letters, numbers, and underscores included in the file name. (2) Based on the new configs run through training, observe the dump configuration file, which is not significantly different from the old configs. As described in the tutorial, only the 'type' field is different, and the new configs file will contain the full information of the module.

Verify the new and old configuration files. There are a total of 10 files:
Verify all configuration files after conversion After verifying the script, there were no errors.

In addition, I also compared the configuration files obtained by running the training dump on the new and old configs, and found that they are only different in the "type" field. The new configs have full information. Some screenshots are as follows:

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories? If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Submitting this pull request means that,

Before PR:

[x] I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
[x] Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
[x] Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
[x] New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[x] The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

[x] If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
[x] CLA has been signed and all committers have signed the CLA in this PR.

LeoXing1996 commented 1 year ago

Hey @hhy150, thanks for your contribution!
Could you please also upload a screenshot of the output of validation script and the generated result to ensure correctness of configs?

hhy150 commented 1 year ago

Verify the new and old configuration files

There are a total of 10 files here:

2. Verify all configuration files after conversion

After verifying the script, there were no errors.

In addition, I also compared the configuration files obtained by running the training dump on the new and old configs, and found that they are only different in the "type" field. The new configs have full information. Some screenshots are as follows:

------------------ 原始邮件 ------------------ 发件人: "open-mmlab/mmagic" @.>; 发送时间: 2023年9月5日(星期二) 晚上8:04 @.>; @.**@.>; 主题: Re: [open-mmlab/mmagic] [CodeCamp2023-652] MMagic 新 config 体验与适配 StyleGAN3 (PR #2018)

Hey @hhy150, thanks for your contribution! Could you please also upload a screenshot of the output of validation script and the generated result to ensure correctness of configs?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

codecov[bot] commented 1 year ago

Codecov Report

Patch has no changes to coverable lines.

:exclamation: Current head a354cd3 differs from pull request most recent head 82aa5aa. Consider uploading reports for the commit 82aa5aa to get more accurate results

Files Changed	Coverage
mmagic/apis/inferencers/base_mmagic_inferencer.py	`0.00%`

:loudspeaker: Thoughts on this report? Let us know!.

open-mmlab / mmagic