open-mmlab / mmcv

OpenMMLab Computer Vision Foundation
https://mmcv.readthedocs.io/en/latest/
Apache License 2.0
5.92k stars 1.66k forks source link

[Feature] Support nms rotated op using diopi #2993

Open POI-WX opened 1 year ago

POI-WX commented 1 year ago

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The Pointpillars model requires the use of the mmcv extension op nms_rotated during the val stage. To support nms_rotated op with the implementation of diopi op, we need the corresponding adaptation in mmcv. When adopting the adaptation, we can get the desired inference result. image

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories? If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

After PR:

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.