this is universally considered a badpractice since it pollutes the namespace for any file including a given header.
In an attempt to reduce this practice in a large codebase, I am enabling -Wheader-hygiene. This breaks for MMCV because of the line above.
If we can remove that line and either use at::Tensor as appropriate or using namespace at; in the implementation (cpp) files, that would solve the problem and align with best practices.
Prerequisite
Environment
LLVM 15 with
-Wheader-hygieneenabled on a project including MMCV.Reproduces the problem - code sample
I don't have a direct reproducer since I'm on a custom build system, but compiling with
-Wheader-hygieneenabled would reproduce the issue.Reproduces the problem - command or script
N/A
Reproduces the problem - error message
N/A
Additional information
This line puts
atin the global namespace:this is universally considered a bad practice since it pollutes the namespace for any file including a given header.
In an attempt to reduce this practice in a large codebase, I am enabling
-Wheader-hygiene. This breaks for MMCV because of the line above.If we can remove that line and either use
at::Tensoras appropriate orusing namespace at;in the implementation (cpp) files, that would solve the problem and align with best practices.