open-mmlab / mmdetection

OpenMMLab Detection Toolbox and Benchmark
https://mmdetection.readthedocs.io
Apache License 2.0
29.21k stars 9.4k forks source link

Purpose allow_negative_crop in train_pipeline of MM Grounding DINO #11723

Open AwePhD opened 4 months ago

AwePhD commented 4 months ago

Hello,

In the base config of MM Grounding DINO, the train_pipeline has a RandomCrop with its allow_negative_crop set to True. Namely, the pipeline can produce an image with no bounding boxes on it.

My question is: why is it there? The BaseDataset.__getitem__ already use a refetch in case the transform return None. I do not see the point to use compute time on frame with no annotations. Anyone can help me to understand this settings please?

Have a nice day, Mathias