open-mmlab / mmdetection3d

OpenMMLab's next-generation platform for general 3D object detection.
https://mmdetection3d.readthedocs.io/en/latest/
Apache License 2.0
5.02k stars 1.49k forks source link

problem about waymo dataset lidar saving #1619

Open AndyYuan96 opened 1 year ago

AndyYuan96 commented 1 year ago

for waymo dataset's lidar saving, why not saving the image position which is cp_points in code for each lidar point, as waymo not only use calibration to convert lidar point to image plane, they have some optimization in waymo-open-dataset repo, I just think use the origin point-to-pixel projection is more accurate,not use calib matrix.

Tai-Wang commented 1 year ago

From our experience, it will not affect the performance a lot, the error caused by the common projection and the waymo optimized version is also minor. Nevertheless, I agree with you that using the official optimized one would be better. It will be better if you can share any experience about it.

Tai-Wang commented 1 year ago

If the influence is a bit large, we will attempt to adjust this afterward.