open-mmlab / mmdetection3d

OpenMMLab's next-generation platform for general 3D object detection.
https://mmdetection3d.readthedocs.io/en/latest/
Apache License 2.0
5.27k stars 1.54k forks source link

[Bug] of DIoU implementation #2766

Open phy12321 opened 1 year ago

phy12321 commented 1 year ago

Prerequisite

Task

I'm using the official example scripts/configs for the officially supported tasks/models/datasets.

Branch

main branch https://github.com/open-mmlab/mmdetection3d

Environment

The definition of DIoU loss: image

And the distance between box_pred center and box_gt center in mmdet3d is implemented as follows: link

I think here should be:

    r2 = ((box3d1[..., :3] - box3d2[..., :3])**2).sum(dim=-1)

If I have any misconceptions, please kindly point them out. I would appreciate a detailed response.

Reproduces the problem - code sample

`

Reproduces the problem - command or script

`

Reproduces the problem - error message

`

Additional information

`

sunjiahao1999 commented 1 year ago

It seems to be a mistake. We will try to re-train the model with the correct loss, thanks for your report!