open-mmlab / mmdetection3d

OpenMMLab's next-generation platform for general 3D object detection.
https://mmdetection3d.readthedocs.io/en/latest/
Apache License 2.0
5.2k stars 1.53k forks source link

Update mono_det3d_inferencer.py #2902

Open SajjadPSavoji opened 7 months ago

SajjadPSavoji commented 7 months ago

remove dependancy to lidar for mono det3D inferencer

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

For mono detection the inferencer should not have dependancy to lidar2cam and lidar2img matrices. But in the current version it loads them as np.asarrays. So if one is using a dataset(public/custom) that does not have lidar sensor, they won't be able to use the inference module. Moreover the networks don't even use those two matrices, making it completely unnecessary to load them in the code.

Modification

added conditions to only load lidar transitions matrices if they are in the annotation data.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.
CLAassistant commented 7 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.